add Unpack for unpacking integers. #80
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #32 I decided to try writing a better and simpler approach that is based off MulAdd but for implementing rshifting and lshifting based on weather or not big or little endians are to be used. In my case I'm going to write a new socks5 protocol parser in C.
I have 2 more forks that will be merged since it's a new function and Node class but I've ensured that there is at least some tests available for it. I do have some skills I've learned from contributing to aiohttp and some of it's lower level C/Cython related code so I should be able to navigate things if the C code is wrong or you think it could be better.
I'll upload those pull requests shortly...
Edit: here's a code snippet from one of the tests I added if anybody is confused about how this new code method works